can you post modified diff please ?hamfratv wrote:THIS IS GENIUS! Thanks a lot!!
Got it to work with 2.32 with a few modifications
Select download folder from web client (diff attached)
Re: Select download folder from web client (diff attached)
Re: Select download folder from web client (diff attached)
I uploaded the modified files to: http://195.140.135.170/transmission-2.32-dirmod.zipkathy wrote:can you post modified diff please ?
Re: Select download folder from web client (diff attached)
This really needs to be a standard feature.
Re: Select download folder from web client (diff attached)
Any chance you could attach an updated diff to the ticket?
Re: Select download folder from web client (diff attached)
I did that nowJordan wrote:Any chance you could attach an updated diff to the ticket?
Re: Select download folder from web client (diff attached)
The patch's coding is fine, but.. hm. I'm torn on this feature. Having an RPC method that returns all the subdirectories of any given path on the server's filesystem... that seems risky, privacy-wise.
Maybe we could use a predefined set of paths instead.
Does anyone else have an opinion on this?
Maybe we could use a predefined set of paths instead.
Does anyone else have an opinion on this?
Re: Select download folder from web client (diff attached)
If you concerned about security you may limit RPC call response to some subtree only, defined in the config. Alternatively you can make an option to use or not the feature. The user will decide. You can combine both approaches.Jordan wrote:The patch's coding is fine, but.. hm. I'm torn on this feature. Having an RPC method that returns all the subdirectories of any given path on the server's filesystem... that seems risky, privacy-wise.
Maybe we could use a predefined set of paths instead.
Does anyone else have an opinion on this?
-
- Posts: 552
- Joined: Sun Dec 13, 2009 10:44 pm
Re: Select download folder from web client (diff attached)
How about listing all directories where you have already saved a torrent in, with the possibility of manually entering one.
Re: Select download folder from web client (diff attached)
Can anyone help me with this please? I am trying to apply this patch to my transmission 2.33 but is not working. This is what the output looks like
(Stripping trailing CRs from patch.)
patching file utils.c
Hunk #1 FAILED at 657.
1 out of 1 hunk FAILED -- saving rejects to file utils.c.rej
(Stripping trailing CRs from patch.)
patching file rpcimpl.c
patch: **** malformed patch at line 32: @@ -30,6 +31,7 @@
Is there something I am doing wrong?
I am running transmission on a headless Ubuntu 10.10 server and I am accessing it via a web browser. I would really appreciate this feature since it is a pain to have to manually move the finished downloads.
Cheers
(Stripping trailing CRs from patch.)
patching file utils.c
Hunk #1 FAILED at 657.
1 out of 1 hunk FAILED -- saving rejects to file utils.c.rej
(Stripping trailing CRs from patch.)
patching file rpcimpl.c
patch: **** malformed patch at line 32: @@ -30,6 +31,7 @@
Is there something I am doing wrong?
I am running transmission on a headless Ubuntu 10.10 server and I am accessing it via a web browser. I would really appreciate this feature since it is a pain to have to manually move the finished downloads.
Cheers
Re: Select download folder from web client (diff attached)
For the security concern I would suggest that the feature is dissabled unless a root folder has been set in the configuration, or a list of folders if you want to be flexible.
I really think the web client needs a folder picking ability.
I really think the web client needs a folder picking ability.
Re: Select download folder from web client (diff attached)
Hello, I have installed the version currently 2.42 in Ubuntu server 11.04. I wanted to know how I can add this option to the version I have currently installed?
Regards,
Regards,
Re: Select download folder from web client (diff attached)
You can't with the installed version. You have to build it from source.luyggy wrote:Hello, I have installed the version currently 2.42 in Ubuntu server 11.04. I wanted to know how I can add this option to the version I have currently installed?
I have not seen the code, but requesting an entire folder tree from say "/" is a possible security hazard and could be very expensive. So starting from a list of root nodes or just from download-dir would be a good starting point. Adding a depth parameter should limit the cost of the request. Also changes in the directory structure on the server should be handled efficiently.
And then there is actually putting it in the UI. I would have very little problems with integrating this in Shift, a new web UI. It can already display the tree structure within a torrent. (TM 2.33) Integrating it with Clutch or Kettu would IMO be slightly harder.