[FIXED] Transmission 1.11 crashes in tr_verifyAdd()

[entidi]

Hi all,

I've a 64bit GnuLinux system and I was using transmission 1.04 since some month without experiencing any problem. After upgrading to 1.11, I had a no more usable transmission because of crashes while trying to start any torrent (transmissioncli working instead).

I was getting the following backtrace:

Code: Select all

#0  0x00002b87f0ad0ba0 in strlen () from /lib64/libc.so.6
#1  0x00002b87f0aa0b9b in vfprintf () from /lib64/libc.so.6
#2  0x00002b87f0ac1d7a in vsnprintf () from /lib64/libc.so.6
#3  0x000000000045c3cf in evbuffer_add_vprintf ()
#4  0x000000000044054e in tr_vasprintf ()
#5  0x000000000044073e in tr_msg ()
#6  0x0000000000440ee7 in tr_verifyAdd ()
#7  0x0000000000437448 in tr_torrentStart ()
#8  0x00000000004204b1 in ?? ()
#9  0x00002b87ec05a409 in gtk_tree_selection_selected_foreach ()
   from /usr/lib64/../lib64/libgtk-x11-2.0.so.0
[...]

My guess is something changed in gcc (I'm using gcc 4.1.2) regardling the tr_{n,tor,}{err,inf,dbg} tricky macro expansion in libtransmission/utils.h: it will be not the first time the ... ## feature chainged the behavior (see http://gcc.gnu.org/ml/gcc/2000-09/msg00604.html ).

Anyway I disabled the gettext() macro to get it working again:

Code: Select all

--- transmission-1.11/libtransmission/utils.h	2008-04-04 21:27:33.000000000 +0200
+++ transmission-1.11-new/libtransmission/utils.h	2008-05-04 10:07:39.000000000 +0200
@@ -42,7 +42,7 @@
   #define _(a) (a)
 #else
   #include <libintl.h>
-  #define _(a) gettext (a)
+  #define _(a) (a)
 #endif
 #endif

[Jordan]

Well, committing that patch to svn would break i18n for everyone else.

I wonder how many people are experiencing this crash.

[entidi]

The bug has been removed in Transmission 1.14 (it was a mismatched arg in tr_msg) so consider it closed.

Thank you for your feedback.