Web Context menu broken with Firefox + Firegestures addon

Discussion of the Web Interface for Transmission, formerly known as Clutch. This applies to all version of Transmission
Post Reply
dino541
Posts: 2
Joined: Fri Jan 07, 2011 4:41 pm

Web Context menu broken with Firefox + Firegestures addon

Post by dino541 »

I'm currently experiencing a problem accessing the web torrent context menu via right click when using the Firefox addon FireGestures. I found a similar post here viewtopic.php?f=8&t=8983&p=41946&hilit=menu but the solution seemed to be disabling the Firefox addon, which doesn't seem like a really elegant solution to me... I'm running Firefox 3.6.13 on Ubunutu Lucid, using both Transmission 1.93 and the latest stable 2.13 builds.

Does anyone else seem to have this problem?

The JQuery plugin which provides the context menu support is about 3.5 years old and was developed on a much older version of Firefox and Jquery http://www.trendskitchens.co.nz/jquery/contextmenu/. I'm wondering if it might be good to use a more modern Jquery context menu? A quick google search returned two alternatives which work just fine with Firefox and the Firegestures add on, which are slightly newer than the one currently in use:

http://abeautifulsite.net/blog/2008/09/ ... nu-plugin/
http://www.smartango.com/articles/jquery-context-menu

If anyone thinks this is a good idea, I'm happy to work on a patch to get this in...
Rolcol
Posts: 337
Joined: Sun Aug 10, 2008 8:00 am

Re: Web Context menu broken with Firefox + Firegestures addo

Post by Rolcol »

Yeah, I've experienced that problem. I didn't know that FireGestures was the cause of it, thanks.
If anyone thinks this is a good idea, I'm happy to work on a patch to get this in...
I don't speak for the developers, but I see no reason why this wouldn't be accepted into Transmission. Even then, I'd like the patch myself :D
livings124
Transmission Developer
Posts: 3142
Joined: Fri Jan 13, 2006 8:08 pm

Re: Web Context menu broken with Firefox + Firegestures addo

Post by livings124 »

dino541: We don't currently have anyone working on the web ui, but we'd love a patch if you can make one!
rb07
Posts: 1400
Joined: Sun Aug 24, 2008 3:14 am

Re: Web Context menu broken with Firefox + Firegestures addo

Post by rb07 »

dino541
Could you describe the actual problem?

Long time ago I had a problem with Firefox, right-click showed the Web client context menu and above it the Firefox context menu. Is that the problem you refer to? If it is then the problem is Firefox not the Web client, the solution was to turn on a Firefox setting which changed with a Firefox update (Tools -> Options... -> Content : Enable JavaScript : Advanced... : Disable or replace context menus).
Rolcol
Posts: 337
Joined: Sun Aug 10, 2008 8:00 am

Re: Web Context menu broken with Firefox + Firegestures addo

Post by Rolcol »

rb07: I've experienced this. The actual problem is that no context menu shows up at all if you have certain Firefox extensions enabled. FireGestures, for me, is the problem, just like it is for dino541.

Edit: Windows version of Firefox works with FireGestures enabled.
dino541
Posts: 2
Joined: Fri Jan 07, 2011 4:41 pm

Re: Web Context menu broken with Firefox + Firegestures addo

Post by dino541 »

rb07: I did try adjusting the Firefox setting that you described and it doesn't have the desired effect. It would have been a good no-code solution! :D

I did write up a patch based on the context menu at http://abeautifulsite.net/blog/2008/09/ ... nu-plugin/ which was last updated on March 2010 (don't be fooled by the url), so the context menu code is relatively new.

livings124: I'm not entirely sure what the protocol is for submitting code changes. I only saw that people interested in writing code should talk to one of the developers (on one of the Transmission web pages), there wasn't too much discussion about what happens next. FYI - I'm a seasoned web developer for the financial services industry and have worked for a number of different web development shops, but I know that every team works a little differently so I'm happy to read and follow any rules and procedures for submitting code changes as the Transmission dev team would like them.

I have tested my fix against the limited number of browsers and platforms which I can emulate, but if you have some sort of automated testing tool for all browsers, then I'd use that to make sure that I didn't accidentally break anything. Do you have any web test harnesses for testing the functionality of the web client (a la Selenium or tools like it?)
livings124
Transmission Developer
Posts: 3142
Joined: Fri Jan 13, 2006 8:08 pm

Re: Web Context menu broken with Firefox + Firegestures addo

Post by livings124 »

Great dino541! The best way to submit patches is to open tickets on trac.transmissionbt.com. Unfortunately we don't have any automated testing for the browser - that was one of the goals at one point, but we're without a dedicated developer for the web client so it suffers with little support.
Post Reply