Russian encoding CP1251 support patch

[pianist]

Hi!

Tranmission is nice, and it works fine with UTF-8 filenames. But sometimes bad windows users make torrents with not-utf8 filenames.

Transmission uses ISO-8859-1 for this strings, but it is not suitable for russian users like me.

I've patched Transmission daemon (but not gtk yet, sorry ), now it has one more parameter in config — russian_enabled. Default is 0. Is it possible to commit my patches? Any suggestions?

Everything (patch and patched source tarball) is located here:

http://lemmatizer.org/transmission/patch/

If it is possible to commit my patch, I will also patch gtk version.

[pianist]

Added gtk patch, everything works fine.

http://lemmatizer.org/transmission/patch/

[livings124]

The bittorrent specs says:

ll character string values are UTF-8 encoded.

http://wiki.theory.org/BitTorrentSpecification

[pianist]

The bittorrent specs says:

Nevertheless ugly windows software generates torrents with non-utf8 strings. What shall we do? I've patched Transmission for my needs, and I know that other people have the same problem.

I'm going to do another patch, which will be configurable not only for CP1251 encoding, but others. By default it will use ISO-8859-1.

[Jordan]

A lot of the code that you're patching no longer exists in svn trunk.

You might want to do a trunk checkout and see how that goes.

[pianist]

Ok, I will checkout the trunk and make another version.

[ili4]

This problem still very relevant. For instance, I'm using Transmission on embedded system (router with OpenWRT). Downloaded files saved to USB drive (with FAT32 filesystem). I plug this USB drive to my PC with Windows and Windows can't understand filenames in UTF-8.
I know that Transmission follows all BitTorrent specifications, but most russian users uses Windows, and Windows unfortunatly can understand filenames only in cp1251.

I found many topics on russian forums where users describes the same problem. But there is no acceptable solution.

I talked with pianist, he can make patch to newest version. But only if it will be commited. This feature will be disabled by default and can be enabled in config. For example, it can be as option "filesystem_encoding", where user can override default encoding (utf8).

So, please, tell me, if pianist does pretty nice patch, will you commit it to the trunk?

Thanks.

[starmoon]

keep watch.

add a universal option says "filesystem_encoding" is best way to impliment this feature.

On systems that can auto-detect local filesystem encoding don't need this option.