Build #2534 Crash

[Sodomy]

I was downloading a torrent with multiple mp3s. As soon as the download was done, Transmission crashed. This crashy washy seems directly related to the code change, 'cause when I looked in the console:

3/5/10 3:52:48 PM [0x0-0x2f02f].org.m0k.transmission[217] Assertion failed: (comparePieceByWeight( &t->pieces, &t->pieces[i+1] ) <= 0), function assertWeightedPiecesAreSorted, file /Users/transmission/hudson/workspace/trunk-mac/trunk/libtransmission/peer-mgr.c, line 743.

And line 743 is one of the changed lines.

Here's the crash report: http://transmission.pastebin.com/L8J6C6XL

What's going on, Chuck?

[Sodomy]

Happened again. This time I was downloading a single mp3 file out of a torrent with multiple mp3s. On Transmission's own error log before it crashed, it listed something about pieces failing a hash check, and downloading them again. Dunno if that's related. But here's the assertion fail:

3/6/10 12:19:13 AM [0x0-0x18b18b].org.m0k.transmission[778] Assertion failed: (comparePieceByWeight( &t->pieces, &t->pieces[i+1] ) <= 0), function assertWeightedPiecesAreSorted, file /Users/transmission/hudson/workspace/trunk-mac/trunk/libtransmission/peer-mgr.c, line 743.

Here's the full crash report:

http://transmission.pastebin.com/ZNwRv8Wb

Gonna revert to the previous build until that code is fixed.

[Jordan]

Thanks for the crash report. I'm looking into this.